-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also test if python files were changed #1264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
added
backport-humble
This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
backport-iron
This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
labels
Aug 22, 2024
github-actions
bot
requested review from
aprotyas,
bmagyar,
DasRoteSkelett,
destogl,
mcbed,
moriarty and
peterdavidfagan
August 22, 2024 12:37
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1264 +/- ##
==========================================
+ Coverage 80.43% 80.45% +0.01%
==========================================
Files 105 105
Lines 9353 9351 -2
Branches 818 816 -2
==========================================
Hits 7523 7523
Misses 1556 1556
+ Partials 274 272 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
bmagyar
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wunderbar!
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
(cherry picked from commit cdfc0af)
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
(cherry picked from commit cdfc0af)
This was referenced Aug 22, 2024
bmagyar
pushed a commit
that referenced
this pull request
Aug 22, 2024
bmagyar
pushed a commit
that referenced
this pull request
Aug 22, 2024
RobertWilbrandt
pushed a commit
to RobertWilbrandt/ros2_controllers
that referenced
this pull request
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-humble
This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
backport-iron
This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the CI jobs are not running in #1259
Not that we would have any tests for rqt_jtc, but just in case we get some.